Conversation
|
- Keep showing the full candidate list when a step is selected - Show conversion rate for each step - Update title - Add total conversion rate and dropoff rate - Add refresh button - Add path connectors - Change starting/end point toggle into an inline dropdown - Add color coding for pageviews vs custom events - Remove "Visit" prefix from pageview steps - Update columns and steps visually
sanne-san
force-pushed
the
sanne-explore-ui
branch
from
902afc3 to
fa53e57
Compare
- Remove drop-off rate - De-emphasize dimmed items and emphasized selected items - Remove color coding for custom events and add cursor icon instead - Update aggregated subpath styling to `/page > all (N)`
- Fix: remove PathConnectors SVG width attribute that prevented scroll container from shrinking - Improved dark mode - Add Suggest journey button when nothing is selected
sanne-san
force-pushed
the
sanne-explore-ui
branch
from
b97300b to
c4995f8
Compare
- Update header DOM structure to accomodate mobile layout - Improve scroll behavior when adding/removing steps: it now always scrolls to the next step, also on mobile
- Improve empty states copy and styling - Remove `Suggest journey` button on second thought - Show only an empty column 2 when nothing is selected rather than two empty columns (2 and 3) with a duplicate empty state. In order to do so we switched to a grid layout to avoid layout shifts. Only for > sm screens. - Hide search input when nothing is selected.
Member
|
The visitor counts are being dragged from one step to another before ending up with final value. record-2026-04-29-11-39-48-skim.tanh.flax.mp4 |
aerosol
reviewed
Apr 29, 2026
|
|
||
| journeyVersionRef.current++ | ||
| setDirection(nextDirection) | ||
| setSteps(steps.toReversed()) |
Member
There was a problem hiding this comment.
Is this deliberate to start over instead of reversing the journey?
| const journeyVersion = journeyVersionRef.current | ||
| preloadedSteps.forEach((_, idx) => { | ||
| const prefix = preloadedSteps.slice(0, idx) | ||
| fetchNextWithFunnel( |
Member
There was a problem hiding this comment.
@zoldar this is making essentially N+1 calls to next-with-funnel
Member
|
The paths go bonkers if you change e.g. query range on an already selected journey 
|
aerosol
reviewed
Apr 29, 2026
|
|
||
| const observer = new ResizeObserver(recalculate) | ||
| observer.observe(container) | ||
| window.addEventListener('resize', recalculate) |
Member
There was a problem hiding this comment.
why is this even here? makes no difference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Changelog
Documentation
Dark mode